Fixed Adafruit_GFX font size limitation - the 8-bit signed values prevented large fonts from working #448
Conversation
|
No idea what the problem is because it just shows "error 1". Useless. |
I disagree with that. Let's say there are 100 glyphs in a font. This change adds 5 bytes per glyph, so 500 bytes to that font, even for apps that will never work with huge fonts. People pack their apps pretty tightly into that 32kB PROGMEM space. If they have a few fonts the cost will be multiplied again. We may disagree as to whether a 2-ish % overhead is significant, but it's not correct to flatly state that there's no downside. |
| CFLAGS = -Wall -I/usr/local/include/freetype2 -I/usr/include/freetype2 -I/usr/include -I/opt/homebrew/include/freetype2 | ||
| LIBS = -L/opt/homebrew/lib -lfreetype |
There was a problem hiding this comment.
These paths apply to your machine.
The right way to figure out where freetype2 is, would be to have the Makefile invoke and save the output of:
freetype-config --libs and freetype-config --cflags.
On my machine, I get different answers.
$ freetype-config --libs
-L/opt/homebrew/opt/freetype/lib -lfreetype
$ freetype-config --cflags
-I/opt/homebrew/opt/freetype/include/freetype2 -I/opt/homebrew/opt/libpng/include/libpng16But Makefile tweaks are a different PR I think.
The details are in the failure report: https://github.com/adafruit/Adafruit-GFX-Library/actions/runs/9206826415/job/25325537261?pr=448 Your code needs be in a state that running clang-format on it would produce no changes. Widening the types pushed the |
This is a simple change which allows the fontconverter and Adafruit GFX font logic to work with fonts larger than about 90 pt. The original code used signed 8-bit values for the character offsets and yAdvance. These overflow when working with fonts past about 90 points. There is no downside to this fix; adding a few bytes to the size of the GFXglyph structure won't negatively impact anything.